From mboxrd@z Thu Jan 1 00:00:00 1970 From: Changli Gao Subject: Re: [PATCH v2] ipv4: netfilter: ipt_CLUSTERIP: fix buffer overflow Date: Thu, 17 Mar 2011 20:15:06 +0800 Message-ID: References: <1299780740-32652-1-git-send-email-segoon@openwall.com> <4D7F5CAC.6070006@trash.net> <20110317113229.GA7710@albatros> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Patrick McHardy , linux-kernel@vger.kernel.org, security@kernel.org, "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org To: Vasiliy Kulikov Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:44895 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752910Ab1CQMP2 convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2011 08:15:28 -0400 In-Reply-To: <20110317113229.GA7710@albatros> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Thu, Mar 17, 2011 at 7:32 PM, Vasiliy Kulikov = wrote: > 'buffer' string is copied from userspace. =A0It is not checked whethe= r it is > zero terminated. =A0This may lead to overflow inside of simple_strtou= l(). > Changli Gao suggested to copy not more than user supplied 'size' byte= s. > > It was introduced before the git epoch. =A0Files "ipt_CLUSTERIP/*" ar= e > root writable only by default, however, on some setups permissions mi= ght be > relaxed to e.g. network admin user. > > Signed-off-by: Vasiliy Kulikov Acked-by: Changli Gao --=20 Regards, Changli Gao(xiaosuo@gmail.com) -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html