From: Changli Gao <xiaosuo@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: [RFC] don't copy the whole table to all the other CPUs
Date: Wed, 17 Nov 2010 22:54:13 +0800 [thread overview]
Message-ID: <AANLkTinBSZPAMKb7J0aBb4_xBv_QPnXTZAE9c+8=cnHz@mail.gmail.com> (raw)
When reviewing the iptables code, I find there is one exact copy of
table on every possible CPU for parallel processing. However, only
counters are private, and the others are the same. It is a wast of
memory. I know the current implementation maybe good for NUMA, but I
don't think NUMA is common, and I doubt its benefit. I'll try to
convert the code use one shared table, but private counters.
Any comment?
--
Regards,
Changli Gao(xiaosuo@gmail.com)
next reply other threads:[~2010-11-17 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 14:54 Changli Gao [this message]
2010-11-17 14:56 ` [RFC] don't copy the whole table to all the other CPUs Patrick McHardy
2010-11-17 14:57 ` Eric Dumazet
2010-11-17 18:03 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinBSZPAMKb7J0aBb4_xBv_QPnXTZAE9c+8=cnHz@mail.gmail.com' \
--to=xiaosuo@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).