From: Changli Gao <xiaosuo@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"Oleg A. Arkhangelsky" <sysoleg@yandex.ru>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Paul E McKenney <paulmck@linux.vnet.ibm.com>
Subject: Re: Kernel panic nf_nat_setup_info+0x5b3/0x6e0
Date: Sat, 21 May 2011 23:42:49 +0800 [thread overview]
Message-ID: <BANLkTikrCBcCm4qksA-8u0n+vTwiuc=WuA@mail.gmail.com> (raw)
In-Reply-To: <4D9B01DF.2050206@trash.net>
On Tue, Apr 5, 2011 at 7:49 PM, Patrick McHardy <kaber@trash.net> wrote:
>
> I think what's happening is that the conntrack entry is destroyed
> and the NAT ct_extend destructor invoked, which removes the nat
> extension from the RCU protected bysource hash, after which the
> entire extension area is freed. Another CPU might still find the
> old NAT entry with undefined contents in the hash though, so I
> think using RCU to free the extension area is correct.
>
What is the conclusion? Is my patch acceptable? Thanks.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
prev parent reply other threads:[~2011-05-21 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 17:07 Kernel panic nf_nat_setup_info+0x5b3/0x6e0 "Oleg A. Arkhangelsky"
2011-03-02 11:37 ` Patrick McHardy
2011-03-02 14:37 ` Changli Gao
2011-03-02 19:50 ` "Oleg A. Arkhangelsky"
2011-03-03 7:33 ` Changli Gao
2011-03-26 15:44 ` Changli Gao
2011-03-31 14:03 ` "Oleg A. Arkhangelsky"
2011-03-31 14:47 ` Eric Dumazet
2011-04-01 2:02 ` Changli Gao
2011-04-01 5:30 ` Eric Dumazet
2011-04-05 11:49 ` Patrick McHardy
2011-05-21 15:42 ` Changli Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikrCBcCm4qksA-8u0n+vTwiuc=WuA@mail.gmail.com' \
--to=xiaosuo@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sysoleg@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).