netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Grant <jg@jguk.org>
To: netfilter-devel@vger.kernel.org
Subject: kernel source code files with same name (different case) xt_*
Date: Tue, 26 Apr 2011 21:47:07 +0100	[thread overview]
Message-ID: <BANLkTinDLPBeYkLE17cyhQg5m-_ZTWbgXg@mail.gmail.com> (raw)

Hello

When extracting kernel source on a partition which does not support
filenames with different case of the same letters (NTFS), I noticed
/include/linux/netfilter/ files have a CAPS version, and lower case
version. The netfilter/KBuild file refers to the CAPS file in certain
cases, which then simply includes the lower-case filename.

Would a patch be considered for review which amended the
netfilter/KBuild to simply refer to the lower-case files, and deleted
the CAPS version files?

An alternative idea would be to make them alphabetically unique. e.g.
appending_def to the CAPS filenames (i.e. xt_CONNMARK_def.h). Of cause
both of these options depend on if agreement that having
alphabetically unique names is something worth the change.

linux kernel files with different case

Looking at 2.6.38.3

/include/linux/netfilter/


xt_CONNMARK.h
includes "xt_connmark.h"

xt_DSCP.h  (contains struct)
xt_dscp.h

xt_MARK.h
includes "xt_mark.h"

xt_RATEEST.h  (contains struct)
xt_rateest.h

xt_TCPMSS.h  (contains struct)
xt_tcpmss.h


There are two other files in ip4 folder, in addition C files:

ipt_ecn.c
xt_dscp.c
xt_hl.c
xt_rateest.c
xt_tcpmss.c

I know ideally we'd only extract the tar.bz on a regular GNU+Linux
system (ext4 formatted partition). Would a patch to rename these files
to be alphabetically unique be accepted for review?

I will wait for reply before starting to prepare a patch. In addition,
then I would look into the files comprehensively.

Thank you for reading this far. Please keep my email address included
in any replies.
Cheers, Jon

             reply	other threads:[~2011-04-26 20:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 20:47 Jon Grant [this message]
2011-04-26 20:48 ` kernel source code files with same name (different case) xt_* David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinDLPBeYkLE17cyhQg5m-_ZTWbgXg@mail.gmail.com \
    --to=jg@jguk.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).