From mboxrd@z Thu Jan 1 00:00:00 1970 From: Willem de Bruijn Subject: Re: [PATCH v2 1/2] iptables: support match info fixup after tc_init Date: Mon, 18 Sep 2017 13:50:32 -0400 Message-ID: References: <20170917112031.8644-1-shmulik@nsof.io> <20170917112031.8644-2-shmulik@nsof.io> <20170918162811.GA6091@salvia> <20170918200042.3189aa0f@pixies> <20170918172353.GA8982@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Shmulik Ladkani , netfilter-devel , rbk@nsof.io, Rafael Buchbinder To: Pablo Neira Ayuso Return-path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:43028 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755294AbdIRRvF (ORCPT ); Mon, 18 Sep 2017 13:51:05 -0400 Received: by mail-wm0-f42.google.com with SMTP id a137so14387862wma.0 for ; Mon, 18 Sep 2017 10:51:04 -0700 (PDT) In-Reply-To: <20170918172353.GA8982@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Sep 18, 2017 at 1:23 PM, Pablo Neira Ayuso wrote: > On Mon, Sep 18, 2017 at 08:00:42PM +0300, Shmulik Ladkani wrote: >> Hi Pablo, >> >> On Mon, 18 Sep 2017 18:28:11 +0200 Pablo Neira Ayuso wrote: >> >> > > >> > > + /* Fixes the match info after init. */ >> > > + void (*tc_init_fixup)(struct xt_entry_match *match); >> > >> > If this is only broken from tc ipt actions, could you fix this from >> > iproute2/tc instead? >> >> No, this is not iproute2/tc specfic. > > OK. > >> We named it 'tc_init_fixup' as it occurs just after the TC_INIT >> (iptc_init/ip6tc_init) call. >> If this is confusing, we can rename to 'init_fixup' or 'post_init_fixup' >> or 'iptc_init_fixup'. >> >> This must occur after every load of entries, as the xt_bpf match needs >> a fixup once read from kernel. >> >> The problem lies in the xt_bpf_info_v1 ABI. >> See: >> https://marc.info/?l=netfilter-devel&m=150530909630143&w=2 > > I see, can we get a v2 ABI that fixes this? Given this was included > not long time ago, we can quickly deprecate this without this custom > hook to address this. We can perhaps change the kernel module to ignore .fd and do a path lookup for .path directly inside the kernel. That would not require a v2, even.