From: Willem de Bruijn <willemb@google.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@plumgrid.com>,
Daniel Borkmann <dborkman@redhat.com>,
keescook@chromium.org
Subject: Re: [PATCH net-next 1/2] netfilter: xt_bpf: don't include linux/filter.h from uapi header
Date: Tue, 29 Jul 2014 11:43:57 -0400 [thread overview]
Message-ID: <CA+FuTSdRmnFYK1mTFh14UP1rTkU-EYK-61xyoWWiNvZR3Aig6A@mail.gmail.com> (raw)
In-Reply-To: <1406648188-3681-1-git-send-email-pablo@netfilter.org>
> In e6f30c7 ("netfilter: x_tables: add xt_bpf match"), the internal
> linux/filter.h header slipped through in the user exposed xt_bpf.h
> header as included file.
is that true? #include <linux/filter.h> should include
include/uapi/linux/filter.h in userspace builds.
>
> +struct sk_filter;
> +
> struct xt_bpf_info {
> __u16 bpf_program_num_elem;
> struct sock_filter bpf_program[XT_BPF_MAX_NUM_INSTR];
I think include/uapi/linux/filter.h is still needed for the definition
of struct sock_filter.
The uapi file does not declare sk_filter, so we do need to add the
forward declaration. Thanks, Pablo.
next prev parent reply other threads:[~2014-07-29 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 15:36 [PATCH net-next 1/2] netfilter: xt_bpf: don't include linux/filter.h from uapi header Pablo Neira Ayuso
2014-07-29 15:36 ` [PATCH net-next 2/2] net: filter: don't release unattached filter through call_rcu() Pablo Neira Ayuso
2014-07-29 16:09 ` Alexei Starovoitov
2014-07-31 2:57 ` David Miller
2014-07-29 15:43 ` Willem de Bruijn [this message]
2014-07-29 16:05 ` [PATCH net-next 1/2] netfilter: xt_bpf: don't include linux/filter.h from uapi header Pablo Neira Ayuso
2014-07-29 16:35 ` Willem de Bruijn
2014-07-29 17:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTSdRmnFYK1mTFh14UP1rTkU-EYK-61xyoWWiNvZR3Aig6A@mail.gmail.com \
--to=willemb@google.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=keescook@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).