Re: [PATCH v2 2/2] selftests: netfilter: add nfnetlink ACK handling tests

[Nikolaos Gkarlis <nickgarlis@gmail.com>]

Florian Westphal <fw@strlen.de> wrote:
> Is this to exercise replay path?
> Perhaps add a comment to the subtest that depends on this.

Yes, that is the goal. I can add a comment to the test explaining that.

> What happens when nft_ct is builtin? The test should not fail
> in that case.

No, the test does not fail when nft_ct is builtin or missing. It only
verifies the number of ACKs returned and their order, which is what
bf2ac490d28c broke. I have tested both builtin and non-existent cases.

> No, if you need nft_ct to not be loaded then the rmmod has to
> be used, but there is no guarantee it will work, e.g. because
> nft_ct is builtin or because it's in use.

What do you think about something like this?

+++ b/tools/testing/selftests/net/netfilter/nfnetlink.sh
@@ -0,0 +1,5 @@
+#!/bin/bash
+
+# If nft_ct is a module and is loaded, remove it to test module auto-loading
+lsmod | grep -q "^nft_ct\b" && rmmod nft_ct
+./nfnetlink

I can send a v3 if that looks okay to you.