netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Ojea <aojea@google.com>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Eric Dumazet <edumazet@google.com>,
	 netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] selftests: nft_queue: conntrack expiration requeue
Date: Tue, 21 Oct 2025 23:57:49 +0200	[thread overview]
Message-ID: <CAAdXToQ+DuBsPGQUgSCk2=f_b2222iTD4-rT=0gVuaYWT7A2HQ@mail.gmail.com> (raw)
In-Reply-To: <aPd6Ch7h6wdJa-eE@strlen.de>

> Looks like one needs to set a label somewhere, no need for it to match.
>
> chain never { ct label set foo }
>
> makes this work for me.
> We could change this so that *checking* a label also turns on the
> extension infra.
>
> Back then i did not want to allocate the extra space for
> the extensions and i did not want to add to a new sysctl either.
>
> So I went with 'no rules that adds one, no need for ct label
> extension space allocation'.

But that does not consider the people that just use netlink to set the
labels ... from a 1k altitude , can you do a check on the first
update/create/delete label to initialize the extension?


Another question related, is it required for the label value to be
always 16 bytes?
I do not know if is the golang libraries I'm using but it seems it
does not work with other lengths

  reply	other threads:[~2025-10-21 21:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 20:08 [PATCH] selftests: nft_queue: conntrack expiration requeue Antonio Ojea
2025-10-20 20:55 ` Florian Westphal
2025-10-20 21:23   ` Antonio Ojea
2025-10-20 22:08     ` Florian Westphal
2025-10-21 10:40       ` Antonio Ojea
2025-10-21 10:45         ` Florian Westphal
2025-10-21 12:05           ` Antonio Ojea
2025-10-21 12:18             ` Florian Westphal
2025-10-21 21:57               ` Antonio Ojea [this message]
2025-10-22 11:26                 ` Florian Westphal
2025-10-22 14:15                   ` Antonio Ojea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdXToQ+DuBsPGQUgSCk2=f_b2222iTD4-rT=0gVuaYWT7A2HQ@mail.gmail.com' \
    --to=aojea@google.com \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).