From: Xiao Liang <shaw.leon@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_exthdr: Fix non-linear header modification
Date: Fri, 25 Aug 2023 11:23:36 +0800 [thread overview]
Message-ID: <CABAhCOTHyEvrGFcKxpO0uD1mwRKFds6HmP0eC8hHVT8wxOMj0g@mail.gmail.com> (raw)
In-Reply-To: <20230825031110.GA9265@breakpoint.cc>
On Fri, Aug 25, 2023 at 11:11 AM Florian Westphal <fw@strlen.de> wrote:
>
> > @@ -325,9 +324,9 @@ static void nft_exthdr_tcp_strip_eval(const struct nft_expr *expr,
> > if (skb_ensure_writable(pkt->skb, nft_thoff(pkt) + tcphdr_len))
>
> Just use the above in nft_exthdr_tcp_set_eval and place it before the loop?
Sure. Need to pull the entire TCP header with skb_ensure_writable() then.
next prev parent reply other threads:[~2023-08-25 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 2:14 [PATCH nf] netfilter: nft_exthdr: Fix non-linear header modification Xiao Liang
2023-08-25 3:11 ` Florian Westphal
2023-08-25 3:23 ` Xiao Liang [this message]
2023-08-25 3:34 ` Xiao Liang
2023-08-25 3:52 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABAhCOTHyEvrGFcKxpO0uD1mwRKFds6HmP0eC8hHVT8wxOMj0g@mail.gmail.com \
--to=shaw.leon@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).