From: Changli Gao <xiaosuo@gmail.com>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net, eric.dumazet@gmail.com
Subject: Re: [PATCH] netfilter: ctnetlink: get and zero operations must be atomic
Date: Sun, 25 Dec 2011 22:09:24 +0800 [thread overview]
Message-ID: <CABa6K_Ev77vYC7sFphT5CNAOMRMChVi-Lxoww_zODVBCCb-vdw@mail.gmail.com> (raw)
In-Reply-To: <1324734508-15043-1-git-send-email-pablo@netfilter.org>
On Sat, Dec 24, 2011 at 9:48 PM, <pablo@netfilter.org> wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
>
> The get and zero operations have to be done in an atomic context,
> otherwise counters added between them will be lost.
>
> This problem was spotted by Changli Gao while discussing the
> nfacct infrastructure.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Reviewed-by: Changli Gao <xiaosuo@gmail.com>
--
Regards,
Changli Gao(xiaosuo@gmail.com)
prev parent reply other threads:[~2011-12-25 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-24 13:48 [PATCH] netfilter: ctnetlink: get and zero operations must be atomic pablo
2011-12-25 14:09 ` Changli Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABa6K_Ev77vYC7sFphT5CNAOMRMChVi-Lxoww_zODVBCCb-vdw@mail.gmail.com \
--to=xiaosuo@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).