From: "Rafał Miłecki" <zajec5@gmail.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH V2] ipvs: disable inline net_ipvs function with CONFIG_IP_VS not being set
Date: Wed, 25 Mar 2015 21:15:37 +0100 [thread overview]
Message-ID: <CACna6rx88PSANYixdj8Fwdg57j997z9Cft-mx_72tCOJ0Rk5tw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1503252148420.1795@ja.home.ssi.bg>
On 25 March 2015 at 21:04, Julian Anastasov <ja@ssi.bg> wrote:
>
> Hello,
>
> On Wed, 25 Mar 2015, Rafał Miłecki wrote:
>
>> Including net/ip_vs.h without CONFIG_IP_VS was causing:
>> include/net/ip_vs.h: In function 'net_ipvs':
>> include/net/ip_vs.h:35:12: error: 'struct net' has no member named 'ipvs'
>>
>> Fixes: 8b4d14d8eb368 ("netns: exclude ipvs from struct net when IPVS disabled")
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> ---
>> V2: Disable function totally instead of returning NULL.
>
> While this version is better, the commit message
> looks scary, it should explain that problem happens only
> for modules out of kernel tree, we do not want other admins
> to wonder whether they need this commit for their trees.
OK, I just need some decision if you want/need this patch at all and
if I should send another version.
> And of course, it is better to implement your
> own ip_vs_check_diff4 version, it is some inline stuff...
I did.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-03-25 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 8:53 [PATCH] ipvs: fix header inline net_ipvs function to work without CONFIG_IP_VS Rafał Miłecki
2015-03-25 9:03 ` Nicolas Dichtel
2015-03-25 9:17 ` [PATCH V2] ipvs: disable inline net_ipvs function with CONFIG_IP_VS not being set Rafał Miłecki
2015-03-25 10:25 ` Nicolas Dichtel
2015-03-25 11:08 ` Rafał Miłecki
2015-03-25 13:12 ` Nicolas Dichtel
2015-03-25 20:04 ` Julian Anastasov
2015-03-25 20:15 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACna6rx88PSANYixdj8Fwdg57j997z9Cft-mx_72tCOJ0Rk5tw@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=coreteam@netfilter.org \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).