Re: [libnftnl PATCH 1/3] ruleset: Add an end of line in the exit of ruleset.

[Ana Rey <anarey@gmail.com>]

2014-04-09 12:11 GMT+02:00 Arturo Borrero Gonzalez
<arturo.borrero.glez@gmail.com>:
> On 9 April 2014 10:53, Ana Rey <anarey@gmail.com> wrote:
>> Add an end of line in the exit of ruleset.
>>
>> Signed-off-by: Ana Rey <anarey@gmail.com>
>
> Hi Ana,
>
> Why do you need this here?
>
> The policy was to don't add any format stuff (tabs, newlines..) to
> XML|JSON formats and let the caller add the trailing \n if needed..

Thank you for this advise. I'll remember it the next time.

I solved this problem in the tests/nft-parsing-test.c

(I'll send a new version of "[libnftnl PATCH 2/3] tests: New tools to
uptade xml and json testfiles." patch and I deleted it of tihs
patchset)

Thank you!

>
> However, I see several inconsistencies already in the code:
> src/rule.c: ret = snprintf(buf+offset, len, "\n");
> src/rule.c: ret = snprintf(buf+offset, len, "]\n");
> src/rule.c: ret = snprintf(buf+offset, len, " }\n");
> src/set.c: ret = snprintf(buf+offset, len, "\n");
>
> --
> Arturo Borrero González



-- 
Ana Rey (@anaRB)
http://about.me/anarey
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html