From: Xin Long <lucien.xin@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
netfilter-devel@vger.kernel.org,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets
Date: Wed, 16 Aug 2017 20:39:44 +1200 [thread overview]
Message-ID: <CADvbK_cCQY0McHiZFKSTjdGdAjhB6RBej5n=SH2=hsLYC=Xa7w@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpXbtHDxVjZ=DoTiLXHLQy6q=JVBa66EqSOy95ZbFg-wkQ@mail.gmail.com>
On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Mon, Aug 7, 2017 at 7:33 PM, Xin Long <lucien.xin@gmail.com> wrote:
>> On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>> This looks like a completely API burden?
>> netfilter xt targets are not really compatible with netsched action.
>> I've got to say, the patch is just a way to make checkentry return
>> false and avoid panic. like [1] said
>
> I don't doubt you fix a crash, I am thinking if we can
> "fix" the API instead of fixing the caller.
Hi, Cong,
For now, I don't think it's possible to change APIs or some of their targets
for the panic caused by action xt calling.
The common way should be fixed in net_sched side.
Given that the issue is very easy to triggered,
let's wait for netfilter's replies for another few days,
otherwise I will repost the fix, agree ?
>
> I am not familiar with this API, so just my 2 cents...
next prev parent reply other threads:[~2017-08-16 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0fa9a53725dd661571461cf283ec88cf15f4b139.1501932907.git.lucien.xin@gmail.com>
2017-08-07 21:15 ` [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets Cong Wang
2017-08-08 2:33 ` Xin Long
2017-08-08 19:33 ` Cong Wang
2017-08-16 8:39 ` Xin Long [this message]
2017-08-17 5:57 ` Cong Wang
2017-08-17 7:45 ` Xin Long
2017-08-17 10:02 ` Pablo Neira Ayuso
2017-08-17 10:33 ` Pablo Neira Ayuso
2017-08-17 11:24 ` Xin Long
2017-08-17 12:44 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADvbK_cCQY0McHiZFKSTjdGdAjhB6RBej5n=SH2=hsLYC=Xa7w@mail.gmail.com' \
--to=lucien.xin@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).