From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xin Long Subject: Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets Date: Wed, 16 Aug 2017 20:39:44 +1200 Message-ID: References: <0fa9a53725dd661571461cf283ec88cf15f4b139.1501932907.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: network dev , David Miller , netfilter-devel@vger.kernel.org, Jamal Hadi Salim To: Cong Wang Return-path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:38036 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbdHPIjp (ORCPT ); Wed, 16 Aug 2017 04:39:45 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: > On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: >> On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang wrote: >>> This looks like a completely API burden? >> netfilter xt targets are not really compatible with netsched action. >> I've got to say, the patch is just a way to make checkentry return >> false and avoid panic. like [1] said > > I don't doubt you fix a crash, I am thinking if we can > "fix" the API instead of fixing the caller. Hi, Cong, For now, I don't think it's possible to change APIs or some of their targets for the panic caused by action xt calling. The common way should be fixed in net_sched side. Given that the issue is very easy to triggered, let's wait for netfilter's replies for another few days, otherwise I will repost the fix, agree ? > > I am not familiar with this API, so just my 2 cents...