* Re: [PATCHv2 net-next 5/5] net: move the nat function to nf_nat_ovs for ovs and tc
[not found] ` <Y35r87foLmKAblMg@t14s.localdomain>
@ 2022-12-01 16:26 ` Xin Long
0 siblings, 0 replies; only message in thread
From: Xin Long @ 2022-12-01 16:26 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: network dev, dev, ovs-dev, davem, kuba, Eric Dumazet, Paolo Abeni,
Pravin B Shelar, Jamal Hadi Salim, Cong Wang, Jiri Pirko,
Pablo Neira Ayuso, Florian Westphal, Davide Caratti, Oz Shlomo,
Paul Blakey, Ilya Maximets, Eelco Chaudron, Aaron Conole,
netfilter-devel
On Wed, Nov 23, 2022 at 1:52 PM Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
>
> On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> > --- a/net/netfilter/Makefile
> > +++ b/net/netfilter/Makefile
> > @@ -52,7 +52,7 @@ obj-$(CONFIG_NF_CONNTRACK_SANE) += nf_conntrack_sane.o
> > obj-$(CONFIG_NF_CONNTRACK_SIP) += nf_conntrack_sip.o
> > obj-$(CONFIG_NF_CONNTRACK_TFTP) += nf_conntrack_tftp.o
> >
> > -nf_nat-y := nf_nat_core.o nf_nat_proto.o nf_nat_helper.o
> > +nf_nat-y := nf_nat_core.o nf_nat_proto.o nf_nat_helper.o nf_nat_ovs.o
>
> Considering that the code in nf_nat_ovs is only used if ovs or act_ct
> are enabled, shouldn't it be using an invisible knob here that gets
> automatically selected by them? Pablo?
It's good to not build it if no place is using it.
Making nf_nat_ovs a module might be too much.
If it's okay to Netfilter devel, I will change to use "ifdef" in Makefile:
+ifdef CONFIG_OPENVSWITCH
+nf_nat-y += nf_nat_ovs.o
+else ifdef CONFIG_NET_ACT_CT
+nf_nat-y += nf_nat_ovs.o
+endif
+
Thanks.
>
> I think this is my last comment on this series. The rest LGTM.
>
> >
> > obj-$(CONFIG_NF_LOG_SYSLOG) += nf_log_syslog.o
> >
^ permalink raw reply [flat|nested] only message in thread