Re: Packet statistics accounting module: request for comments

[Julien Lafaye <jlafaye@gmail.com>]

Jan

> I still think this could be integrated, perhaps as an extra option to
> choose a particular recording mode, to xt_quota2 (including the fifo).
> Speaking of which, your module seems to lack locking on the ctx, so it's
> not very consistent on SMP as of yet.
>

I will fix the usage of the fifo so that there is not any odd behavior
in SMP context.

As for the inclusion into xt_quota2, I am bit skeptical, for three reasons:

- the two modules, xt_quota2  and xt_pktstat, have different features:
quota enforcement and poll-based network accounting for the first one,
and event driven high resolution network accounting for the second
one. Where I agree that the two modules could share portions of code,
I don't see how the core parts can be merged. I fear that merging the
modules would require putting the two codes side by side and not
actually merging them. But you have more experience than me on
netfilter modules, and obviously on xt_quota2, and you could give me
some hints on how to merge them in a way that would benefit the two
projects.

- xt_quota2 is clearly not a good name for the feature I propose.

- since the features provided by xt_quota2 and xt_pktstat are
separated, why trying to join them into a swiss-army knife with two
sets of parameters: one to be used for a first feature and the other
one for a second feature. This could prove to be misleading for the
user.

What do you think ?

Regards,

Julien