From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 899E7C43334 for ; Mon, 11 Jul 2022 19:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230186AbiGKToT (ORCPT ); Mon, 11 Jul 2022 15:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbiGKToS (ORCPT ); Mon, 11 Jul 2022 15:44:18 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1904BF69 for ; Mon, 11 Jul 2022 12:44:17 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id h23so10532862ejj.12 for ; Mon, 11 Jul 2022 12:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BwEDVdKbnbZtn9p0uC93yaXB5Vwp4sXmO/V6mgJc1hE=; b=Opt4AN70UWDNIKd9DrhmzqMlFdNVINRChnpwp92hsWrOpZvBTfEZJN7paVV3K1qBFM 7OZBpDZMglnQFlcLjrZ9pDfXTkdTQoUzuP0Hz6eUeQux4XKzh2WKfUasuN2gSwWsHLep DzWiJVcrraZfXmxMQGs9Pb2Y/u1AF7nC4xlTKtrnqEUhJhoVIbnrdnqPX2Iy3Rfk7bXT 5SFxJySXeTvn6G4IFMg7HMX+a9tR0UjYWpLwPE3Q0biZEU0kBbtVAuQNo8jYH7ImbN+0 PlwWct+os2RQ50ZmFHtlRB1eot1RVM7cLSdtJgMbb737jfzbRmo5RVd/r5jq5syWOwH8 K+ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BwEDVdKbnbZtn9p0uC93yaXB5Vwp4sXmO/V6mgJc1hE=; b=ClV+iVtKWRH5lDIztfyVQD7CPdiMfT3I0OWDp42fyJhft7XPSvjFq3Mi6CfCiSh8My B0pfNzY7AJG7vQXzr53h+4k8xkRqgnp3E5q37gFFiXRwU6R1P6DbWUTkJDAxq8Pvp7pv DczaxDvEwpWXC22wAsu2yuqD0mq026cS1VnBluzXwM7MFGa812uLJZlIdiLGE1Dhmj5+ ii9rJI5CS+ALZPbfFcJGyLVdxbV+urQsGlk9XC0Ir06RU6wfC+K9INTNLLq3JymoK7NI ryVLzzE06bAgM7YzKL4pmOMV1tXjQg6t1rVIUhs4yRKcqLPny8dVx6DuYghYQ9cZThVZ zS9Q== X-Gm-Message-State: AJIora/FxarrvpgUErS4f1Cd5Mz0n22G83ivlrFKxGt8zedCRXMnA9Oz D1LWRVwsppM9ePzXv0MIr922kp0R02CEsOkNFM/5OA== X-Google-Smtp-Source: AGRyM1tHofXUqkdW7BnM1C245t2ran6VcnZvUJuKy6J7zLT7nKrsoMbm7F1S99ufXtKPsrkkFHcy/q7Q5UPlTaovmsk= X-Received: by 2002:a17:907:60cc:b0:72b:40a8:a5b with SMTP id hv12-20020a17090760cc00b0072b40a80a5bmr11795359ejc.379.1657568656253; Mon, 11 Jul 2022 12:44:16 -0700 (PDT) MIME-Version: 1.0 References: <20220707191745.840590-1-justinstitt@google.com> In-Reply-To: From: Justin Stitt Date: Mon, 11 Jul 2022 12:44:05 -0700 Message-ID: Subject: Re: [PATCH] netfilter: xt_TPROXY: fix clang -Wformat warnings: To: Pablo Neira Ayuso Cc: Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor , Nick Desaulniers , Tom Rix , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Mon, Jul 11, 2022 at 2:04 AM Pablo Neira Ayuso wrote: > > On Thu, Jul 07, 2022 at 12:17:45PM -0700, Justin Stitt wrote: > > diff --git a/net/netfilter/xt_TPROXY.c b/net/netfilter/xt_TPROXY.c > > index 459d0696c91a..5d74abffc94f 100644 > > --- a/net/netfilter/xt_TPROXY.c > > +++ b/net/netfilter/xt_TPROXY.c > > @@ -169,7 +169,7 @@ tproxy_tg6_v1(struct sk_buff *skb, const struct xt_action_param *par) > > targets on the same rule yet */ > > skb->mark = (skb->mark & ~tgi->mark_mask) ^ tgi->mark_value; > > > > - pr_debug("redirecting: proto %hhu %pI6:%hu -> %pI6:%hu, mark: %x\n", > > + pr_debug("redirecting: proto %d %pI6:%hu -> %pI6:%hu, mark: %x\n", > > tproto, &iph->saddr, ntohs(hp->source), > > laddr, ntohs(lport), skb->mark); > > > > @@ -177,7 +177,7 @@ tproxy_tg6_v1(struct sk_buff *skb, const struct xt_action_param *par) > > return NF_ACCEPT; > > } > > > > - pr_debug("no socket, dropping: proto %hhu %pI6:%hu -> %pI6:%hu, mark: %x\n", > > + pr_debug("no socket, dropping: proto %d %pI6:%hu -> %pI6:%hu, mark: %x\n", > > tproto, &iph->saddr, ntohs(hp->source), > > &iph->daddr, ntohs(hp->dest), skb->mark); > > Could you instead send a patch to remove these pr_debug calls? Do you mean all Instances of pr_debug in `xt_TPROXY.c` (of which there are six) or just these two specific cases @ +169 and +177. > Thanks.