From: Giuseppe Longo <giuseppelng@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [{ip,ip6}tables-compat PATCH] nft: fix network prefixes
Date: Wed, 27 Aug 2014 13:17:14 +0200 [thread overview]
Message-ID: <CAFpD06STYKUKz1UL+ND0yj+XMLU0v3GJy9pu1_fEpnuVCx3RtQ@mail.gmail.com> (raw)
In-Reply-To: <20140826192918.GA3394@salvia>
Hi Pablo,
I catched the mistake.
The nft_ipv*_parse_payload function calls get_cmp_data(),
and it gets the next expression, that's bitwise instead of cmp.
So in nft_rule_to_iptables_command_state() the bitwise expr is skipped.
I could add an operation family like nft_*_parse_cmp, but in this way
I can't set the inverse flag when parsing the payload.
Otherwise, I can implement the parse_bitwise as function and not as
operation family and call it in parse_payload (as done for get_cmp_data).
Another solution could be to add the inverse flag in nft context.
Do you have any hint?
Thanks
prev parent reply other threads:[~2014-08-27 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 20:54 [{ip,ip6}tables-compat PATCH] nft: fix network prefixes Giuseppe Longo
2014-08-26 8:55 ` Pablo Neira Ayuso
2014-08-26 11:43 ` Giuseppe Longo
2014-08-26 11:45 ` Giuseppe Longo
2014-08-26 19:29 ` Pablo Neira Ayuso
2014-08-27 11:17 ` Giuseppe Longo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFpD06STYKUKz1UL+ND0yj+XMLU0v3GJy9pu1_fEpnuVCx3RtQ@mail.gmail.com \
--to=giuseppelng@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).