From: Vaishali Thakkar <vthakkar1994@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate
Date: Fri, 31 Jul 2015 07:33:20 +0530 [thread overview]
Message-ID: <CAK-LDbLQXFtg7S6aQCJiTdt5VmTEx9MWEziD+VEkjKHBx+CL5g@mail.gmail.com> (raw)
In-Reply-To: <20150730122433.GA5948@salvia>
On Thu, Jul 30, 2015 at 5:54 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sun, Jul 26, 2015 at 05:27:37PM +0530, Vaishali Thakkar wrote:
>> For simple modules that contain a single xt_match without any
>> additional setup code then ends up being a block of duplicated
>> boilerplate. This patch adds a new macro, module_xt_match(),
>> which replaces the module_init()/module_exit() registrations with
>> template functions.
>
> I prefer not to use this macro, we may need to add something to the
> module_init()/module_exit() path in the future to these netfilter
> extensions and then we'll have to revert the follow up conversions
> patches that you will likely send.
Ok. This makes sense. I think in that case you can drop the patch.
Thank You.
> Thanks anyway.
--
Vaishali
prev parent reply other threads:[~2015-07-31 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 11:57 [PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate Vaishali Thakkar
2015-07-30 12:24 ` Pablo Neira Ayuso
2015-07-31 2:03 ` Vaishali Thakkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK-LDbLQXFtg7S6aQCJiTdt5VmTEx9MWEziD+VEkjKHBx+CL5g@mail.gmail.com \
--to=vthakkar1994@gmail.com \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).