netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org,
	David Miller <davem@davemloft.net>,
	Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH 40/47] netfilter: nf_tables: build-in filter chain type
Date: Wed, 4 Apr 2018 17:38:31 +0200	[thread overview]
Message-ID: <CAK8P3a1nEJ450Ori2-xPnC8WDPcHxiQR_844ArqOgZ2eRGpcbw@mail.gmail.com> (raw)
In-Reply-To: <20180330114619.18797-1-pablo@netfilter.org>

On Fri, Mar 30, 2018 at 1:46 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> One module per supported filter chain family type takes too much memory
> for very little code - too much modularization - place all chain filter
> definitions in one single file.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Hi Pablo,

I've bisected a link error to this patch:

net/netfilter/nft_reject_inet.o: In function `nft_reject_inet_eval':
nft_reject_inet.c:(.text+0xa7): undefined reference to `nf_send_unreach6'
nft_reject_inet.c:(.text+0x10c): undefined reference to `nf_send_unreach6'
nft_reject_inet.c:(.text+0x138): undefined reference to `nf_send_reset6'

Unfortunately I don't immediately see what went wrong, maybe you
can spot it.

       Arnd

  parent reply	other threads:[~2018-04-04 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 11:46 [PATCH 40/47] netfilter: nf_tables: build-in filter chain type Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 41/47] netfilter: nf_tables: enable conntrack if NAT chain is registered Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 42/47] netfilter: nf_tables: rename to nft_set_lookup_global() Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 43/47] netfilter: nf_tables: use nft_set_lookup_global from nf_tables_newsetelem() Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 44/47] netfilter: Merge assignment with return Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 45/47] netfilter: x_tables: Add note about how to free percpu counters Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 46/47] Revert "netfilter: x_tables: ensure last rule in base chain matches underflow/policy" Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 47/47] netfilter: ipset: Use is_zero_ether_addr instead of static and memcmp Pablo Neira Ayuso
2018-04-04 15:38 ` Arnd Bergmann [this message]
2018-04-04 15:46   ` [PATCH 40/47] netfilter: nf_tables: build-in filter chain type Pablo Neira Ayuso
2018-04-04 15:50     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a1nEJ450Ori2-xPnC8WDPcHxiQR_844ArqOgZ2eRGpcbw@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).