From: Mikhail Sennikovsky <mikhail.sennikovskii@ionos.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, mikhail.sennikovsky@gmail.com
Subject: Re: [PATCH 1/1] conntrack: use same modifier socket for bulk ops
Date: Thu, 9 Jun 2022 12:42:50 +0200 [thread overview]
Message-ID: <CALHVEJbUpxPJ0fSfcyynEkfiTrnvSR_zfrkLPm_0iiOBMr+Tog@mail.gmail.com> (raw)
In-Reply-To: <YqHJhO6K15gzqLnV@salvia>
Sure, let me remove it then and submit an updated patch here.
Thanks,
Mikhail
On Thu, 9 Jun 2022 at 12:20, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> Hi,
>
> On Wed, Jun 08, 2022 at 04:16:34PM +0200, Mikhail Sennikovsky wrote:
> > Hi Pablo,
> >
> > Then I misunderstood you, my bad.
> > Yes, _check is never used for events, and the socket->events is not
> > used anywhere except the assert(events == socket->events); assertion
> > check which I found useful as a sanity check for potential future uses
> > of the nfct_mnl_socket_check_open.
> > If you find it unneeded however, I'm fine with removing it.
>
> If not used now for this usecase, I'd prefer if you remove it.
prev parent reply other threads:[~2022-06-09 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 16:34 [PATCH 0/1] Reusing modifier socket for bulk ct loads Mikhail Sennikovsky
2022-06-02 16:34 ` [PATCH 1/1] conntrack: use same modifier socket for bulk ops Mikhail Sennikovsky
2022-06-08 6:18 ` Pablo Neira Ayuso
2022-06-08 11:02 ` Mikhail Sennikovsky
2022-06-08 11:08 ` Pablo Neira Ayuso
2022-06-08 11:19 ` Pablo Neira Ayuso
2022-06-08 14:16 ` Mikhail Sennikovsky
2022-06-09 10:20 ` Pablo Neira Ayuso
2022-06-09 10:42 ` Mikhail Sennikovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALHVEJbUpxPJ0fSfcyynEkfiTrnvSR_zfrkLPm_0iiOBMr+Tog@mail.gmail.com \
--to=mikhail.sennikovskii@ionos.com \
--cc=mikhail.sennikovsky@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).