Re: [RFC PATCH] netfilter: nf_nat_snmp_basic: snmp_version() can be static

[Taehee Yoo <ap420073@gmail.com>]

2017-12-26 12:25 GMT+09:00 kbuild test robot <lkp@intel.com>:
>
> Fixes: 499b2f89cea8 ("netfilter: nf_nat_snmp_basic: use asn1 decoder library")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  nf_nat_snmp_basic_main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/netfilter/nf_nat_snmp_basic_main.c b/net/ipv4/netfilter/nf_nat_snmp_basic_main.c
> index b6e2770..b16d3ad 100644
> --- a/net/ipv4/netfilter/nf_nat_snmp_basic_main.c
> +++ b/net/ipv4/netfilter/nf_nat_snmp_basic_main.c
> @@ -101,8 +101,8 @@ static void fast_csum(struct snmp_ctx *ctx, unsigned char offset)
>                                              ~csum_unfold(*ctx->check)));
>  }
>
> -int snmp_version(void *context, size_t hdrlen, unsigned char tag,
> -                const void *data, size_t datalen)
> +static int snmp_version(void *context, size_t hdrlen, unsigned char tag,
> +                       const void *data, size_t datalen)
>  {
>         if (*(unsigned char *)data > 1)
>                 return -ENOTSUPP;

After this RFC, I found wrong code in my V4 patch
that is snmp_version() is not used.
I sent V5 patch that fixed this.

Thank you!