From: Liping Zhang <zlpnobody@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: Liping Zhang <zlpnobody@163.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf-next 2/3] netfilter: nf_ct_helper: use nf_ct_iterate_cleanup to unlink helper objs
Date: Sun, 21 May 2017 18:17:30 +0800 [thread overview]
Message-ID: <CAML_gOc1OHEc_evYoXj2f0O1CMGLVc0MMNYgVE0xNtzXPXNJtQ@mail.gmail.com> (raw)
In-Reply-To: <20170521081521.GD1004@breakpoint.cc>
Hi Florian,
2017-05-21 16:15 GMT+08:00 Florian Westphal <fw@strlen.de>:
[...]
> this is broken for unconfirmed conntracks, as
> other cpu can reallocate the extension area.
Right, I missed this point, thanks for your reminder.
> For the module removal case, we have no choice but to toss the
> unconfirmed conntracks.
>
> Same for patch #3.
>
> I plan to submit my patches soon, perhaps its best if I only
> submit the first couple of patches so you can rebase on top of that?
I read your nfct_iterate_cleanup_15 patch series just now.
Your patch set did more jobs, also including all the jobs which
my patch set did. :)
I think it's better to do these things together, so I'm fine if you
can mark my patch set as Superseded. :)
> Alternatively, I'm fine if your patches go in first, I can also
> just rebase on top.
next prev parent reply other threads:[~2017-05-21 10:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 5:39 [PATCH nf-next 0/3] netfilter: handle hash resize situation in nf_ct_iterate_cleanup Liping Zhang
2017-05-21 5:39 ` [PATCH nf-next 1/3] netfilter: restart nf ct cleanup if hash resize happen Liping Zhang
2017-05-21 8:09 ` Florian Westphal
2017-05-21 5:39 ` [PATCH nf-next 2/3] netfilter: nf_ct_helper: use nf_ct_iterate_cleanup to unlink helper objs Liping Zhang
2017-05-21 8:15 ` Florian Westphal
2017-05-21 10:17 ` Liping Zhang [this message]
2017-05-21 10:31 ` Florian Westphal
2017-05-21 11:05 ` Liping Zhang
2017-05-21 11:10 ` Florian Westphal
2017-05-21 5:39 ` [PATCH nf-next 3/3] netfilter: cttimeout: use nf_ct_iterate_cleanup to unlink timeout objs Liping Zhang
2017-05-21 8:07 ` [PATCH nf-next 0/3] netfilter: handle hash resize situation in nf_ct_iterate_cleanup Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAML_gOc1OHEc_evYoXj2f0O1CMGLVc0MMNYgVE0xNtzXPXNJtQ@mail.gmail.com \
--to=zlpnobody@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).