From: Liping Zhang <zlpnobody@gmail.com>
To: Laura Garcia <nevola@gmail.com>
Cc: Liping Zhang <zlpnobody@163.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nft] src: fix compile error due to _UNTIL renamed to _MODULUS in libnftnl
Date: Mon, 12 Sep 2016 17:58:52 +0800 [thread overview]
Message-ID: <CAML_gOe4jyy9+XTEsi5itzzF_c-CqujM7JsWwMHdgocxbdt80Q@mail.gmail.com> (raw)
In-Reply-To: <20160912094919.GA5013@sonyv>
2016-09-12 17:49 GMT+08:00 Laura Garcia <nevola@gmail.com>:
> On Sun, Sep 11, 2016 at 04:35:57PM +0800, Liping Zhang wrote:
>> From: Liping Zhang <liping.zhang@spreadtrum.com>
>>
>> In the latest libnftnl, NFTNL_EXPR_NG_UNTIL was renamed to
>> NFTNL_EXPR_NG_MODULUS, so compile error happened:
>> netlink_linearize.c: In function ‘netlink_gen_numgen’:
>> netlink_linearize.c:184:26: error: ‘NFTNL_EXPR_NG_UNTIL’ undeclared
>> (first use in this function)
>>
>
> In order to complete the renaming, NFTA_NG_UNTIL should be changed to
> NFTA_NG_MODULUS as well.
>
Yes, I missed it. Although NFTA_NG_XXX is not used in nftables, but I think it's
better to do this in one single patch.
prev parent reply other threads:[~2016-09-12 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 8:35 [PATCH nft] src: fix compile error due to _UNTIL renamed to _MODULUS in libnftnl Liping Zhang
2016-09-12 9:49 ` Laura Garcia
2016-09-12 9:58 ` Liping Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAML_gOe4jyy9+XTEsi5itzzF_c-CqujM7JsWwMHdgocxbdt80Q@mail.gmail.com \
--to=zlpnobody@gmail.com \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).