From: Liping Zhang <zlpnobody@gmail.com>
To: Jarno Rajahalme <jarno@ovn.org>
Cc: Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
joe@ovn.org
Subject: Re: [PATCH nf v2] net/openvswitch: Delete conntrack entry clashing with an expectation.
Date: Fri, 14 Apr 2017 12:18:19 +0800 [thread overview]
Message-ID: <CAML_gOeTJoEZPtzMdd0oBg5EES6T5PRZKVjxpmf9X6u7ba0ngA@mail.gmail.com> (raw)
In-Reply-To: <1492124719-123107-1-git-send-email-jarno@ovn.org>
Hi Jarno,
2017-04-14 7:05 GMT+08:00 Jarno Rajahalme <jarno@ovn.org>:
[...]
> + h = nf_conntrack_find_get(net, zone, &tuple);
> + if (h) {
> + struct nf_conn *ct = nf_ct_tuplehash_to_ctrack(h);
> +
> + if (nf_ct_is_confirmed(ct))
If the _ct_ could be got by nf_conntrack_find_get(), it means that
the _ct_ have
been confirmed already, so the judgement "if (nf_ct_is_confirmed(ct))" seems
unnecessary.
> + nf_ct_delete(ct, 0, 0);
> + nf_conntrack_put(&ct->ct_general);
> + }
> + }
next prev parent reply other threads:[~2017-04-14 4:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 23:05 [PATCH nf v2] net/openvswitch: Delete conntrack entry clashing with an expectation Jarno Rajahalme
2017-04-14 4:18 ` Liping Zhang [this message]
2017-04-14 16:49 ` Jarno Rajahalme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAML_gOeTJoEZPtzMdd0oBg5EES6T5PRZKVjxpmf9X6u7ba0ngA@mail.gmail.com \
--to=zlpnobody@gmail.com \
--cc=jarno@ovn.org \
--cc=joe@ovn.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).