From: Liping Zhang <zlpnobody@gmail.com>
To: Gao Feng <gfree.wind@foxmail.com>
Cc: Liping Zhang <zlpnobody@163.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
cernekee@chromium.org
Subject: Re: [PATCH nf] netfilter: ctnetlink: make it safer when updating ct->status
Date: Thu, 13 Apr 2017 11:55:07 +0800 [thread overview]
Message-ID: <CAML_gOez2Tow+4rdSPHqsnmR9YSHuwyQVEiL75GW8+v83LUgjw@mail.gmail.com> (raw)
In-Reply-To: <000201d2b405$3c071920$b4154b60$@foxmail.com>
Hi Feng,
2017-04-13 11:22 GMT+08:00 Gao Feng <gfree.wind@foxmail.com>:
[...]
>> No, it's better to do this together, there are two invocations, it's not good to
>> copy these codes twice.
>
> You mean " on &= ~ IPS_UNCHANGEABLE_MASK " and " off &= ~ IPS_UNCHANGEABLE_MASK " seems duplicated?
I see. I misunderstood your initial meaning. So I will send V2 :)
next prev parent reply other threads:[~2017-04-13 3:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 15:56 [PATCH nf] netfilter: ctnetlink: make it safer when updating ct->status Liping Zhang
2017-04-13 2:42 ` Gao Feng
2017-04-13 3:15 ` Liping Zhang
2017-04-13 3:22 ` Gao Feng
2017-04-13 3:55 ` Liping Zhang [this message]
2017-04-13 2:43 ` Gao Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAML_gOez2Tow+4rdSPHqsnmR9YSHuwyQVEiL75GW8+v83LUgjw@mail.gmail.com \
--to=zlpnobody@gmail.com \
--cc=cernekee@chromium.org \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).