netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neutron Soutmun <neo.neutron@gmail.com>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Jan Engelhardt <jengelh@inai.de>,
	netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [ANNOUNCE] ipset 6.12 released
Date: Thu, 10 May 2012 22:13:53 +0700	[thread overview]
Message-ID: <CAMQP0s=uSzOn-o7jwKLyhTaZud4d04hMN=JXrCQLrFD+6Zinkw@mail.gmail.com> (raw)
In-Reply-To: <CAMQP0sn=2jKYzoiUVu+oTRYj-niL84Lg2Z1UoO0UnFXJjV8Ggw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi,

> However, I'll find the solution for the build system when the
> --disable-dependency-tracking is being parse.

The attached file is a patch to solve the
--disable-dependency-tracking is being parse issue and also fixes the
ipset does not build out of the source tree as the configure script
could not check for the lib/ipset_*.c.

Please review.

Best regards,
Neutron Soutmun

[-- Attachment #2: 0001-build-fix-build-failed-on-disable-dependency-trackin.patch --]
[-- Type: application/octet-stream, Size: 2468 bytes --]

From f1fdaa691bb9a0420865e017b54799c7012533d4 Mon Sep 17 00:00:00 2001
From: Neutron Soutmun <neo.neutron@gmail.com>
Date: Thu, 10 May 2012 21:53:55 +0700
Subject: [PATCH] build: fix build failed on --disable-dependency-tracking

* lib/Make_extra.am:
  - Add macro flags to enable/disable the dependency tracking build
    depends on the configuration.
* configure.ac:
  - Fix the userspace tool configuration section error when build
    out of source tree.
---
 configure.ac      |    2 +-
 lib/Make_extra.am |   15 ++++++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/configure.ac b/configure.ac
index d9a71d3..af19bf4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -222,7 +222,7 @@ if test "x$enable_settype_modules" != "xyes"; then
 else
 	AC_MSG_RESULT([    Dynamic module loading: enabled])
 fi
-IPSET_ALL_MODULES="`ls lib/ipset_*.c|sed -e 's/lib\///' -e 's/\.c$//'`"
+IPSET_ALL_MODULES="`ls ${srcdir}/lib/ipset_*.c|sed -e 's/^.*lib\///' -e 's/\.c$//'`"
 AC_MSG_RESULT([    Static modules:])
 if test "x$SETTYPE_MODLIST" = "x"; then
 	for mod in $IPSET_ALL_MODULES; do
diff --git a/lib/Make_extra.am b/lib/Make_extra.am
index e5e498c..47da701 100644
--- a/lib/Make_extra.am
+++ b/lib/Make_extra.am
@@ -26,11 +26,16 @@ BUILT_SOURCES = ipset_settype_check types_init.c ipset_settype_modules
 CLEANFILES = ipset_settype_check types_init.c $(IPSET_SETTYPE_ALL_MODULES)
 
 ipset_%.lo: ipset_%.c
-	depbase=`echo $@ | sed 's|[^/]*$$|$(DEPDIR)/&|;s|\.lo$$||'`; \
-	$(LTCOMPILE) -D_INIT=ipset_$*_init \
-	  $(if $(findstring ipset_$*.c,$(IPSET_SETTYPE_STATIC)), -DTYPE_INCLUSIVE,)\
-	  -MT $@ -MD -MP -MF $$depbase.Tpo -c -o $@ $< && \
-	$(am__mv) $$depbase.Tpo $$depbase.Plo
+@am__fastdepCC_TRUE@	depbase=`echo $@ | sed 's|[^/]*$$|$(DEPDIR)/&|;s|\.lo$$||'`; \
+@am__fastdepCC_TRUE@	$(LTCOMPILE) -D_INIT=ipset_$*_init \
+		$(if $(findstring ipset_$*.c,$(IPSET_SETTYPE_STATIC)), -DTYPE_INCLUSIVE,)\
+		-MT $@ -MD -MP -MF $$depbase.Tpo -c -o $@ $< && \
+@am__fastdepCC_TRUE@	$(am__mv) $$depbase.Tpo $$depbase.Plo
+@AMDEP_TRUE@@am__fastdepCC_FALSE@	source='$<' object='$@' libtool=yes @AMDEPBACKSLASH@
+@AMDEP_TRUE@@am__fastdepCC_FALSE@	DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@
+@am__fastdepCC_FALSE@	$(LTCOMPILE) -D_INIT=ipset_$*_init \
+		$(if $(findstring ipset_$*.c,$(IPSET_SETTYPE_STATIC)), -DTYPE_INCLUSIVE,)\
+		-c -o $@ $<
 
 ipset_%.la: $(lib_LTLIBRARIES) ipset_%.lo
 	lobj="$(patsubst %.la, %.lo, $@)"; \
-- 
1.7.10


  reply	other threads:[~2012-05-10 15:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 10:18 [ANNOUNCE] ipset 6.12 released Jozsef Kadlecsik
2012-05-10 10:39 ` Jan Engelhardt
2012-05-10 11:17   ` Jozsef Kadlecsik
2012-05-10 11:28     ` Jan Engelhardt
2012-05-10 11:41       ` Jozsef Kadlecsik
2012-05-10 12:12         ` Neutron Soutmun
2012-05-10 15:13           ` Neutron Soutmun [this message]
2012-05-10 15:27             ` Jozsef Kadlecsik
2012-05-10 15:52               ` Neutron Soutmun
2012-05-10 16:00                 ` Neutron Soutmun
2012-05-10 16:28                   ` Neutron Soutmun
2012-05-10 22:00                     ` Mr Dash Four
2012-05-11  2:37                       ` Neutron Soutmun
2012-05-11 12:45                         ` Mr Dash Four
2012-05-11 19:40                           ` Jozsef Kadlecsik
2012-05-11 22:58                             ` Mr Dash Four
2012-05-11 23:06                               ` Jan Engelhardt
2012-05-11 23:20                                 ` Mr Dash Four
2012-05-11  8:40                       ` Jozsef Kadlecsik
2012-05-11  9:00                         ` Neutron Soutmun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMQP0s=uSzOn-o7jwKLyhTaZud4d04hMN=JXrCQLrFD+6Zinkw@mail.gmail.com' \
    --to=neo.neutron@gmail.com \
    --cc=jengelh@inai.de \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).