From: Neutron Soutmun <neo.neutron@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] libmnl: Drop the EXPORT_SYMBOL() tags
Date: Fri, 2 Oct 2015 08:38:03 +0700 [thread overview]
Message-ID: <CAMQP0skhJLGDBYSSLePZTE4TvdBh7fAKkQrcpvEi2hDhax6bJw@mail.gmail.com> (raw)
In-Reply-To: <20151001165035.GB2107@salvia>
On Thu, Oct 1, 2015 at 11:50 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Thu, Oct 01, 2015 at 06:05:21PM +0700, Neutron Soutmun wrote:
>> diff --git a/src/internal.h b/src/internal.h
>> index 3a88d1a..1012df2 100644
>> --- a/src/internal.h
>> +++ b/src/internal.h
>> @@ -2,11 +2,5 @@
>> #define INTERNAL_H 1
>>
>> #include "config.h"
>> -#ifdef HAVE_VISIBILITY_HIDDEN
>> -# define __visible __attribute__((visibility("default")))
>> -# define EXPORT_SYMBOL(x) typeof(x) (x) __visible
>> -#else
>> -# define EXPORT_SYMBOL
>> -#endif
>>
>> #endif
>
> Do we need the internal.h file anymore?
I think, "no".
If what the consensus think is the same, please find the
updated patch [1] - [PATCH v2] libmnl: Drop the EXPORT_SYMBOL() tags
Best regards,
Neutron Soutmun
[1] https://marc.info/?l=netfilter-devel&m=144374965006777&w=2
prev parent reply other threads:[~2015-10-02 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 11:05 [PATCH] libmnl: Drop the EXPORT_SYMBOL() tags Neutron Soutmun
2015-10-01 16:50 ` Pablo Neira Ayuso
2015-10-02 1:38 ` Neutron Soutmun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMQP0skhJLGDBYSSLePZTE4TvdBh7fAKkQrcpvEi2hDhax6bJw@mail.gmail.com \
--to=neo.neutron@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).