Re: [PATCH nft v12]tests: py: add netns feature

[shekhar sharma <shekhar250198@gmail.com>]

On Thu, Jul 4, 2019 at 6:44 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> On Wed, Jul 03, 2019 at 12:50:45AM +0530, Shekhar Sharma wrote:
> > diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py
> > index fcbd28ca..8076ce78 100755
> > --- a/tests/py/nft-test.py
> > +++ b/tests/py/nft-test.py
> > @@ -174,27 +174,31 @@ def print_differences_error(filename, lineno, cmd):
> [...]
> > -def table_create(table, filename, lineno):
> > +def table_create(table, filename, lineno, netns=""):
> >      '''
> >      Adds a table.
> >      '''
> > @@ -208,6 +212,8 @@ def table_create(table, filename, lineno):
> >
> >      # We add a new table
> >      cmd = "add table %s" % table
> > +    if netns:
> > +        cmd = "ip netns exec " + "{} {}".format(netns,cmd)
> >      ret = execute_cmd(cmd, filename, lineno)
> >
> >      if ret != 0:
>
> You're missing updates of table_create() invocations, because you are
> setting a default value to the netns parameter to "", this never runs
> the netns patch I'm afraid.
Ok. I will correct it and send the patch again.