From mboxrd@z Thu Jan  1 00:00:00 1970
From: Harsha Sharma <harshasharmaiitr@gmail.com>
Subject: Re: [PATCH] tests: shell: add testcases for named objects
Date: Mon, 9 Oct 2017 18:03:49 +0530
Message-ID: <CANMOCy0orSvkh1+nRRAdFcnbqmbCwNWckrita3Y2-Q8fcq1TrA@mail.gmail.com>
References: <20171005101539.32010-1-harshasharmaiitr@gmail.com>
 <20171006123835.GC4713@salvia> <CANMOCy0E1zpo_0ajtf0jvvZ7oGB1YKtQNkHAK8wEViiaVnsZ8Q@mail.gmail.com>
 <20171009120233.GA7926@salvia>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: netfilter-devel@vger.kernel.org,
        outreachy-kernel <outreachy-kernel@googlegroups.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from mail-vk0-f68.google.com ([209.85.213.68]:37809 "EHLO
        mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751598AbdJIMdu (ORCPT
        <rfc822;netfilter-devel@vger.kernel.org>);
        Mon, 9 Oct 2017 08:33:50 -0400
Received: by mail-vk0-f68.google.com with SMTP id q75so6805871vkf.4
        for <netfilter-devel@vger.kernel.org>; Mon, 09 Oct 2017 05:33:50 -0700 (PDT)
In-Reply-To: <20171009120233.GA7926@salvia>
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

On Mon, Oct 9, 2017 at 5:32 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sat, Oct 07, 2017 at 01:11:17PM +0530, Harsha Sharma wrote:
>> On Fri, Oct 6, 2017 at 6:08 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>> > On Thu, Oct 05, 2017 at 03:45:39PM +0530, Harsha Sharma wrote:
>> >> Add testcases for creating named objects with unique name, defined
>> >> by user and referencing them from rule.
>> >
>> > Also applied, thanks.
>> >
>> > Could you add another tests for 'limit' objects too? I think I posted
>> > an example to the mailing list.
>>
>> Hello,
>> I have pulled to latest tree, then make and make installed all changes
>> but still I'm unable to add named 'limit' objects. If there is something that
>> I'm missing, please let me know.
>
> Are you using a kernel compiled from nf.git tree?

No, I was using kernel 4.10 but I have build the kernel 4.14 from
nf-git tree now.

>
>> Can you also please suggest some more tasks ?
>
> Yes. It would be great if you could update tests/py/nft-tests.py to
> add a new option, basically to take all tests from files, place them
> in a file and exercise the 'nft -f' path with such an autogenerated
> large file with all tests.
>
> Would you have a look into that?
>

Yes, definitely.
Thanks for your time :).

Regards,
Harsha Sharma

> Thanks.