From: "Maciej Żenczykowski" <zenczykowski@gmail.com>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Linux NetDev <netdev@vger.kernel.org>,
Netfilter Development Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH v4] doc: document danger of applying REJECT to INVALID CTs
Date: Wed, 13 May 2020 09:29:05 -0700 [thread overview]
Message-ID: <CANP3RGdUALH97LB2jHryrFsGYq=h2xwDTVRWuaG_-H-9squsXg@mail.gmail.com> (raw)
In-Reply-To: <20200513093944.9752-1-jengelh@inai.de>
Apparently no, did you send the wrong patch?
But since you'll have to resend again, 2 more minor stylistic comments.
> +P_2 being succesful in reaching its destination and advancing the connection
successful
> +state normally. It is conceivable that the late-arriving P may be considered to
> +be not associated with any connection tracking entry. Generating a reject
s/be not/not be/ is probably better
> +only DROP these.
would 'those' be better?
> +P_2 being succesful in reaching its destination and advancing the connection
ditto
prev parent reply other threads:[~2020-05-13 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 5:22 [PATCH] document danger of '-j REJECT'ing of '-m state INVALID' packets Maciej Żenczykowski
2020-05-09 10:52 ` Jan Engelhardt
2020-05-09 17:45 ` Maciej Żenczykowski
2020-05-09 18:02 ` Maciej Żenczykowski
2020-05-09 21:17 ` [PATCH] doc: document danger of applying REJECT to INVALID CTs Jan Engelhardt
2020-05-09 21:28 ` Maciej Żenczykowski
2020-05-09 21:31 ` Maciej Żenczykowski
2020-05-12 21:00 ` [PATCH v2] " Jan Engelhardt
2020-05-12 21:25 ` Maciej Żenczykowski
2020-05-13 4:39 ` Benjamin Poirier
2020-05-13 9:17 ` [PATCH v3] " Jan Engelhardt
2020-05-13 9:28 ` Maciej Żenczykowski
2020-05-13 9:39 ` [PATCH v4] " Jan Engelhardt
2020-05-13 16:29 ` Maciej Żenczykowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANP3RGdUALH97LB2jHryrFsGYq=h2xwDTVRWuaG_-H-9squsXg@mail.gmail.com' \
--to=zenczykowski@gmail.com \
--cc=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).