Re: [PATCHv3] tests: py: Add test for ambiguity while setting the value

[Shyam Saini <mayhs11saini@gmail.com>]

On Sun, Jun 18, 2017 at 3:18 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sun, Jun 18, 2017 at 11:29:13AM +0200, Pablo Neira Ayuso wrote:
>> On Sat, Jun 17, 2017 at 01:05:42AM +0530, Shyam Saini wrote:
>> > This test checks bug identified and fixed in the commit mentioned below
>> > In a statement if there are  multiple src data then it  would be
>> > totally ambiguous to decide which value to set.
>> >
>> > Before the commit was made it returned 134(BUG), but now it returns 1
>> > i.e, an error message.
>>
>> Applied, thanks.
>>
>> One change though before applying, see below.
>
> BTW, shouldn't we check for explicit exit code 1 in rule_add() in
> tests/py/?
>
>> > Test: 986dea8 ("evaluate: avoid reference to multiple src data in
>> > statements which set values")
>
> It would be good to run this test with and without 986dea8.
>
> If we hit exit code 134, the py test should complain even if we say
> "fail".
>
> Basically, test py with 'fail' is fine if we fail gracefully, not if
> we hit BUG.
>
> Probably just a matter of making a oneline patch for nft-tests.py to
> enforce this?
Patch sent,

Thanks