Re: [libnftables PATCH v2] Basic support for printing nft_data_reg in XML format.

[Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>]

2013/4/9 Pablo Neira Ayuso <pablo@netfilter.org>:
>
> Cannot use "data" instead of immediate data? This is nested in
> <immediate>...</immediate>, it seems redundant to me.

Understood. And I will fix it.

But let me explain why I did it:

for example, cmp is using <cmpdata>
<cmpdata> has <data_reg></data_reg> which can also be redundant.

But all around the XML printing (including sets, an incoming patch)
i've been nesting the data_reg into another XML node, so you could
easily see (also the XML parser) the difference between (for example.
in set) nft_set_elem->key and nft_set_elem->data.
As I needed to nest in nft_set_elem I decided to follow a constant
line and do nest all data_reg.

If you liked this reason, we can choose a new tag for immediate and
cmp (or a general naming convention) to avoid be so redundant. If not,
I'll fix it and resend.

regards
--
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html