From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arturo Borrero Gonzalez Subject: Re: [PATCH 33/34] netfilter: nf_tables: store and dump set policy Date: Wed, 1 Oct 2014 15:47:16 +0200 Message-ID: References: <1411994363-8451-1-git-send-email-pablo@netfilter.org> <1411994363-8451-34-git-send-email-pablo@netfilter.org> <54298583.3020100@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Pablo Neira Ayuso , Netfilter Development Mailing list , davem@davemloft.net, "netdev@vger.kernel.org" To: Sergei Shtylyov Return-path: Received: from mail-lb0-f173.google.com ([209.85.217.173]:58500 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbaJANri convert rfc822-to-8bit (ORCPT ); Wed, 1 Oct 2014 09:47:38 -0400 In-Reply-To: <54298583.3020100@cogentembedded.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 29 September 2014 18:14, Sergei Shtylyov wrote: >> >> index a476b99..19e79f0 100644 >> --- a/net/netfilter/nf_tables_api.c >> +++ b/net/netfilter/nf_tables_api.c >> @@ -2344,6 +2344,11 @@ static int nf_tables_fill_set(struct sk_buff = *skb, >> const struct nft_ctx *ctx, >> goto nla_put_failure; >> } >> >> + if (set->policy !=3D NFT_SET_POL_PERFORMANCE) { >> + if (nla_put_be32(skb, NFTA_SET_POLICY, >> htonl(set->policy))) >> + goto nla_put_failure; > > > Why not fold these two *if* stetement into a single one? > I don't have any preference. Should I send a patch to change it? regards. --=20 Arturo Borrero Gonz=C3=A1lez -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html