netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
To: Ana Rey <anarey@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [libnftnl PATCH 0/5] queue: Do not print unset value
Date: Fri, 13 Jun 2014 12:51:20 +0200	[thread overview]
Message-ID: <CAOkSjBjUnR6kjdFuWypJCe2igogmoUMfahvMHb5KxcE22wFu=Q@mail.gmail.com> (raw)
In-Reply-To: <1402651913-15065-1-git-send-email-anarey@gmail.com>

On 13 June 2014 11:31, Ana Rey <anarey@gmail.com> wrote:
> This patchset does tasks about does not print unset value in xml and json file
> and about refactoring code: "Add nft_rule_expr_queue_snprinf_* functions"
> and "Use nft_rule_expr_* in the xml".
>
> Also, It fixes some data type of variables.
>
> Ana Rey (5):
>   expr: queue: Add nft_rule_expr_queue_snprinf_* functions
>   expr: queue: Use nft_rule_expr_* in the xml
>   expr: queue: Do not print unset values in xml
>   expr: queue: Do not print unset values in json
>   expr: queue: Use the correct data type.
>
>  src/expr/queue.c | 161 ++++++++++++++++++++++++++++++++++---------------------
>  1 file changed, 101 insertions(+), 60 deletions(-)
>

Hi Ana,

I've reviewed this series, and except the small thing in 1/5, they
seem OK to me.

thanks, regards.

-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-06-13 10:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  9:31 [libnftnl PATCH 0/5] queue: Do not print unset value Ana Rey
2014-06-13  9:31 ` [libnftnl PATCH 1/5] expr: queue: Add nft_rule_expr_queue_snprinf_* functions Ana Rey
2014-06-13 10:16   ` Arturo Borrero Gonzalez
2014-06-13  9:31 ` [libnftnl PATCH 2/5] expr: queue: Use nft_rule_expr_* in the xml Ana Rey
2014-06-13  9:31 ` [libnftnl PATCH 3/5] expr: queue: Do not print unset values in xml Ana Rey
2014-06-13  9:31 ` [libnftnl PATCH 4/5] expr: queue: Do not print unset values in json Ana Rey
2014-06-13  9:31 ` [libnftnl PATCH 5/5] expr: queue: Use the correct data type Ana Rey
2014-06-13 10:51 ` Arturo Borrero Gonzalez [this message]
2014-06-16 10:11 ` [libnftnl PATCH 0/5] queue: Do not print unset value Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOkSjBjUnR6kjdFuWypJCe2igogmoUMfahvMHb5KxcE22wFu=Q@mail.gmail.com' \
    --to=arturo.borrero.glez@gmail.com \
    --cc=anarey@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).