From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Anastasov Subject: Re: [patch nf-next v2] IPVS: ICMPv6 checksum calculation Date: Wed, 25 Aug 2010 22:55:29 +0300 (EEST) Message-ID: References: <20100825080832.GA24863@verge.net.au> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Patrick McHardy , David Miller , Xiaoyu Du To: Simon Horman Return-path: In-Reply-To: <20100825080832.GA24863@verge.net.au> Sender: lvs-devel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org Hello, On Wed, 25 Aug 2010, Simon Horman wrote: > Cc: Xiaoyu Du > Cc: Julian Anastasov Signed-off-by: Julian Anastasov should be enough > Signed-off-by: Simon Horman > > -- > > Xiaoyu, is this the change that you tested? > If so could you give me a Tested-by line? > > Julian, could I get an ack from you? > Alternatively, if you want to take ownership of the patch, > can I get a signed-off-by from you? In that case I'll change > the From accordingly. > > Index: nf-next-2.6/net/netfilter/ipvs/ip_vs_core.c > =================================================================== > --- nf-next-2.6.orig/net/netfilter/ipvs/ip_vs_core.c 2010-08-25 16:57:37.000000000 +0900 > +++ nf-next-2.6/net/netfilter/ipvs/ip_vs_core.c 2010-08-25 17:02:35.000000000 +0900 > @@ -637,9 +637,11 @@ void ip_vs_nat_icmp_v6(struct sk_buff *s > } > > /* And finally the ICMP checksum */ > - icmph->icmp6_cksum = 0; > - /* TODO IPv6: is this correct for ICMPv6? */ > - ip_vs_checksum_complete(skb, icmp_offset); > + icmph->icmp6_cksum = ~csum_ipv6_magic(&iph->saddr, &iph->daddr, > + skb->len - icmp_offset, > + IPPROTO_ICMPV6, 0); > + skb->csum_start = skb_network_header(skb) - skb->head + icmp_offset; > + skb->csum_offset = offsetof(struct icmp6hdr, icmp6_cksum); > skb->ip_summed = CHECKSUM_UNNECESSARY; > > if (inout) > Regards -- Julian Anastasov