From: Jesper Dangaard Brouer <hawk@diku.dk>
To: Cong Wang <amwang@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
"Netfilter Developers" <netfilter-devel@vger.kernel.org>,
"Herbert Xu" <herbert@gondor.hengli.com.au>,
"Michal Kubeček" <mkubecek@suse.cz>,
"David Miller" <davem@davemloft.net>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
"Patrick McHardy" <kaber@trash.net>,
"Pablo Neira Ayuso" <pablo@netfilter.org>
Subject: Re: [PATCH 2/4] ipv6: unify conntrack reassembly expire code with standard one
Date: Wed, 19 Sep 2012 17:12:46 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1209191659150.12601@ask.diku.dk> (raw)
In-Reply-To: <1348023011-16195-3-git-send-email-amwang@redhat.com>
On Wed, 19 Sep 2012, Cong Wang wrote:
[cut]
> With this patch applied, I can see ICMP Time Exceeded sent
> from the receiver when the sender sent out 3/4 fragmented
> IPv6 UPD packet.
Typo "UPD" -> "UDP"
If people want to redo the IPv6 UDP fragment tests, they can use my scapy
script, and comment out sending the last fragment:
https://github.com/netoptimizer/network-testing/blob/master/scapy/ipv6_fragment01.py
Another thing, could you please "mark"/put the version of the patch in the
subject line, like:
[PATCH V4 2/4] ipv6: ...
This makes it easier, to follow on which version of the patch people are
replying to.
With git send-email I think you have to do:
git send-email --subject-prefix="PATCH V4"
And with stg (stacked git) I usually do:
stg mail --version "V4" --to netdev ...
Cheers,
Jesper Brouer
--
-------------------------------------------------------------------
MSc. Master of Computer Science
Dept. of Computer Science, University of Copenhagen
Author of http://www.adsl-optimizer.dk
-------------------------------------------------------------------
next prev parent reply other threads:[~2012-09-19 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 2:50 [PATCH v4 net-next 0/4] ipv6: fix the reassembly expire code in nf_conntrack Cong Wang
2012-09-19 2:50 ` [PATCH 1/4] ipv6: add a new namespace for nf_conntrack_reasm Cong Wang
2012-09-19 2:50 ` [PATCH 2/4] ipv6: unify conntrack reassembly expire code with standard one Cong Wang
2012-09-19 15:12 ` Jesper Dangaard Brouer [this message]
2012-09-20 7:41 ` Cong Wang
2012-09-19 2:50 ` [PATCH 3/4] ipv6: make ip6_frag_nqueues() and ip6_frag_mem() static inline Cong Wang
2012-09-19 2:50 ` [PATCH 4/4] ipv6: unify fragment thresh handling code Cong Wang
2012-09-19 21:28 ` [PATCH v4 net-next 0/4] ipv6: fix the reassembly expire code in nf_conntrack David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-09-18 13:45 [PATCH v3 " Cong Wang
2012-09-18 13:45 ` [PATCH 2/4] ipv6: unify conntrack reassembly expire code with standard one Cong Wang
2012-09-18 4:29 [PATCH v2 net-next 0/4] ipv6: fix the reassembly expire code in nf_conntrack Cong Wang
2012-09-18 4:29 ` [PATCH 2/4] ipv6: unify conntrack reassembly expire code with standard one Cong Wang
2012-09-13 6:25 [PATCH net-next 0/4] ipv6: fix the reassembly expire code in nf_conntrack Cong Wang
2012-09-13 6:25 ` [PATCH 2/4] ipv6: unify conntrack reassembly expire code with standard one Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1209191659150.12601@ask.diku.dk \
--to=hawk@diku.dk \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=kaber@trash.net \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).