From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E49C4332F for ; Wed, 19 Oct 2022 06:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbiJSGor (ORCPT ); Wed, 19 Oct 2022 02:44:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbiJSGoq (ORCPT ); Wed, 19 Oct 2022 02:44:46 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F40C826573 for ; Tue, 18 Oct 2022 23:44:44 -0700 (PDT) Date: Wed, 19 Oct 2022 08:44:41 +0200 From: Pablo Neira Ayuso To: Ian Pilcher Cc: netfilter-devel@vger.kernel.org Subject: Re: [RFC PATCH 1/1] libnftnl: Fix res_id byte order Message-ID: References: <20221018164528.250049-1-arequipeno@gmail.com> <20221018164528.250049-2-arequipeno@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221018164528.250049-2-arequipeno@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Oct 18, 2022 at 11:45:28AM -0500, Ian Pilcher wrote: > The res_id member of struct nfgenmsg is supposed to be in network > byte order (big endian). Call htons() in __nftnl_nlmsg_build_hdr() > to ensure that this is true on little endian systems. LGTM, this is zero all the time at this moment. But it might be useful in the future to bump it.