Linux Netfilter development
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Robert O'Brien <robrien@foxtrot-research.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: PATCH ulogd2 filter BASE ARP packet IP addresses
Date: Fri, 11 Nov 2022 12:09:28 +0100	[thread overview]
Message-ID: <Y24taNAVtz53JPDB@salvia> (raw)
In-Reply-To: <005601d8f532$49cd7080$dd685180$@foxtrot-research.com>

On Thu, Nov 10, 2022 at 01:28:53PM -0500, Robert O'Brien wrote:
> I am developing for an embedded target and just recently deployed
> libnetfilter and ulogd2 for logging packets which are rejected by rules in
> ebtables. While performing this effort I discovered a bug which generates
> incorrect values in the arp.saddr and arp.daddr fields in the OPRINT and
> GPRINT outputs. I created a patch to resolve this issue in my deployment and
> I believe it is a candidate for integration into the repository. The files
> that this patch modifies have not changed in many years so I'm thinking that
> the bug appeared due to changes in another codebase but I'm not sure. Please
> review and provide feedback.

Could you post an example ulogd configuration file to reproduce the
issue?

> P.S. I could not find a way to submit a patch via Patchwork so I am writing
> this email and attaching the patch. If there is a better way to submit a
> patch, please tell me and I will re-submit it that way.

For patches to show up in patchwork, you have to use the git
format-patch and git send-email tools.

Thanks.

  reply	other threads:[~2022-11-11 11:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <004301d8f531$bb2c60c0$31852240$@foxtrot-research.com>
2022-11-10 18:28 ` PATCH ulogd2 filter BASE ARP packet IP addresses Robert O'Brien
2022-11-11 11:09   ` Pablo Neira Ayuso [this message]
2022-11-14 17:47     ` Robert O'Brien
2022-11-14 18:12       ` Pablo Neira Ayuso
2022-11-21 22:52         ` Jeremy Sowden
2022-11-23 20:14           ` Jeremy Sowden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y24taNAVtz53JPDB@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=robrien@foxtrot-research.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox