From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9215EC4332F for ; Tue, 15 Nov 2022 09:40:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232883AbiKOJkP (ORCPT ); Tue, 15 Nov 2022 04:40:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237315AbiKOJkJ (ORCPT ); Tue, 15 Nov 2022 04:40:09 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A3A00186E2; Tue, 15 Nov 2022 01:40:08 -0800 (PST) Date: Tue, 15 Nov 2022 10:40:07 +0100 From: Pablo Neira Ayuso To: Jakub Kicinski Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com Subject: Re: [PATCH net-next 3/6] netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters Message-ID: References: <20221114104106.8719-1-pablo@netfilter.org> <20221114104106.8719-4-pablo@netfilter.org> <20221114190405.24cebc06@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221114190405.24cebc06@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Mon, Nov 14, 2022 at 07:04:05PM -0800, Jakub Kicinski wrote: > On Mon, 14 Nov 2022 11:41:03 +0100 Pablo Neira Ayuso wrote: > > From: Phil Sutter > > > > Add a 'reset' flag just like with nft_object_ops::dump. This will be > > useful to reset "anonymous stateful objects", e.g. simple rule counters. > > > > No functional change intended. > > This one appears to break the build transiently (next patch fixes it). > Any chance for a rebase? Bisection potentially getting broken by this > and all that.. I will send v2.