From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Cc: Florian Westphal <fw@strlen.de>
Subject: Re: [iptables PATCH 1/4] libxtables: xt_xlate_add() to take care of spacing
Date: Tue, 29 Nov 2022 13:32:12 +0100 [thread overview]
Message-ID: <Y4X7zMSBlaPmZGZN@orbyte.nwl.cc> (raw)
In-Reply-To: <20221125161229.18406-1-phil@nwl.cc>
On Fri, Nov 25, 2022 at 05:12:26PM +0100, Phil Sutter wrote:
> Try to eliminate most of the whitespace issues by separating strings
> from separate xt_xlate_add() calls by whitespace if needed.
>
> Cover the common case of consecutive range, list or MAC/IP address
> printing by inserting whitespace only if the string to be appended
> starts with an alphanumeric character or a brace. The latter helps to
> make spacing in anonymous sets consistent.
>
> Provide *_nospc() variants which disable the auto-spacing for the
> mandatory exception to the rule.
>
> Make things round by dropping any trailing whitespace before returning
> the buffer via xt_xlate_get().
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Series applied.
prev parent reply other threads:[~2022-11-29 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 16:12 [iptables PATCH 1/4] libxtables: xt_xlate_add() to take care of spacing Phil Sutter
2022-11-25 16:12 ` [iptables PATCH 2/4] extensions: Leverage xlate auto-spacing Phil Sutter
2022-11-25 16:12 ` [iptables PATCH 3/4] extensions: libxt_conntrack: Drop extra whitespace in xlate Phil Sutter
2022-11-25 16:12 ` [iptables PATCH 4/4] extensions: xlate: Format sets consistently Phil Sutter
2022-11-29 12:32 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4X7zMSBlaPmZGZN@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).