From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43ED2C4321E for ; Fri, 2 Dec 2022 12:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233338AbiLBMyb (ORCPT ); Fri, 2 Dec 2022 07:54:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232971AbiLBMy3 (ORCPT ); Fri, 2 Dec 2022 07:54:29 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 08033CCFF2 for ; Fri, 2 Dec 2022 04:54:27 -0800 (PST) Date: Fri, 2 Dec 2022 13:54:24 +0100 From: Pablo Neira Ayuso To: Alex Forster Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [PATCH] json: fix 'add flowtable' command Message-ID: References: <20221202033501.48129-1-aforster@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221202033501.48129-1-aforster@cloudflare.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Dec 01, 2022 at 09:35:01PM -0600, Alex Forster wrote: > In `json_parse_cmd_add_flowtable`, the format arguments passed to `json_unpack` are incorrect: the object key name ("dev") is not provided. Applied to nftables, thanks