From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21EEFC3A5A7 for ; Thu, 8 Dec 2022 12:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiLHMYB (ORCPT ); Thu, 8 Dec 2022 07:24:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbiLHMYA (ORCPT ); Thu, 8 Dec 2022 07:24:00 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A13FB7617C for ; Thu, 8 Dec 2022 04:23:59 -0800 (PST) Date: Thu, 8 Dec 2022 13:23:56 +0100 From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [iptables PATCH 4/7] nft: Fix match generator for '! -i +' Message-ID: References: <20221201163916.30808-1-phil@nwl.cc> <20221201163916.30808-5-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221201163916.30808-5-phil@nwl.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Dec 01, 2022 at 05:39:13PM +0100, Phil Sutter wrote: > It's actually nonsense since it will never match, but iptables accepts > it and the resulting nftables rule must behave identically. Reuse the > solution implemented into xtables-translate (by commit e179e87a1179e) > and turn the above match into 'iifname INVAL/D'. Maybe starting bailing out in iptables-nft when ! -i + is used at ruleset load time? As you mentioned, this rule is really useless / never matching.