From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH ulogd2 2/4] filter: fix buffer sizes in filter plug-ins
Date: Thu, 8 Dec 2022 22:07:33 +0100 [thread overview]
Message-ID: <Y5JSFbQVlHUbMMM/@salvia> (raw)
In-Reply-To: <20221203190212.346490-3-jeremy@azazel.net>
On Sat, Dec 03, 2022 at 07:02:10PM +0000, Jeremy Sowden wrote:
[...]
> The arrays are indexed by subtracting `START_KEY` from the enum value of
> the key currently being processed: `hwmac_str[okey - START_KEY]`.
> However, this means that the last key (`KEY_MAC_ADDR` in this example)
> will run off the end of the array. Increase the size of the arrays.
BTW, did you detect this via valgrind or such? If so, posting an
extract of the splat in the commit message is good to have.
Just a side note for your follow up patches, this batch is already on
git.netfilter.org
Thanks.
next prev parent reply other threads:[~2022-12-08 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 19:02 [PATCH ulogd2 0/4] Some bug-fixes Jeremy Sowden
2022-12-03 19:02 ` [PATCH ulogd2 1/4] ulogd: fix parse-error check Jeremy Sowden
2022-12-03 19:02 ` [PATCH ulogd2 2/4] filter: fix buffer sizes in filter plug-ins Jeremy Sowden
2022-12-08 21:07 ` Pablo Neira Ayuso [this message]
2022-12-08 21:21 ` Jeremy Sowden
2022-12-03 19:02 ` [PATCH ulogd2 3/4] JSON: remove incorrect config value check Jeremy Sowden
2022-12-03 19:02 ` [PATCH ulogd2 4/4] db: fix back-log capacity checks Jeremy Sowden
2022-12-08 20:58 ` [PATCH ulogd2 0/4] Some bug-fixes Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5JSFbQVlHUbMMM/@salvia \
--to=pablo@netfilter.org \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).