From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] netlink: unfold function to generate concatenations for keys and data
Date: Thu, 8 Dec 2022 22:24:48 +0100 [thread overview]
Message-ID: <Y5JWIGTy7hlegf8O@salvia> (raw)
In-Reply-To: <20221208013217.483019-2-pablo@netfilter.org>
On Thu, Dec 08, 2022 at 02:32:17AM +0100, Pablo Neira Ayuso wrote:
> Add a specific function to generate concatenation with and without
> intervals in maps. This restores the original function added by
> 8ac2f3b2fca3 ("src: Add support for concatenated set ranges") which is
> used by 66746e7dedeb ("src: support for nat with interval
> concatenation") to generate the data concatenations in maps.
>
> Only the set element key requires the byteswap introduced by 1017d323cafa
> ("src: support for selectors with different byteorder with interval
> concatenations"). Therefore, better not to reuse the same function for
> key and data as the future might bring support for more kind of
> concatenations in data maps.
This patch needs more work, netlink_gen_concat_key() is still called
for rhs element data in a mapping in this patch.
I'll post a v2.
prev parent reply other threads:[~2022-12-08 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 1:32 [PATCH nft] evaluate: do not crash on runaway number of concatenation components Pablo Neira Ayuso
2022-12-08 1:32 ` [PATCH nft] netlink: unfold function to generate concatenations for keys and data Pablo Neira Ayuso
2022-12-08 21:24 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5JWIGTy7hlegf8O@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).