From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH ulogd2] pgsql: correct `ulog2.ip_totlen` type
Date: Thu, 8 Dec 2022 22:27:08 +0100 [thread overview]
Message-ID: <Y5JWrNpThFqFTOon@salvia> (raw)
In-Reply-To: <20221129211127.246934-1-jeremy@azazel.net>
On Tue, Nov 29, 2022 at 09:11:27PM +0000, Jeremy Sowden wrote:
> The types of `ip_totlen` in the `ulog` view and the `INSERT_IP_PACKET_FULL`
> function are `integer`, but the column in the `ulog2` table is `smallint`. The
> "total length" field of an IP packet is an unsigned 16-bit integer, whereas
> `smallint` in PostgreSQL is a signed 16-bit integer type. Change the type of
> `ulog2.ip_totlen` to `integer`.
Also applied this to ulogd2, thanks.
prev parent reply other threads:[~2022-12-08 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 21:11 [PATCH ulogd2] pgsql: correct `ulog2.ip_totlen` type Jeremy Sowden
2022-12-08 21:27 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5JWrNpThFqFTOon@salvia \
--to=pablo@netfilter.org \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).