From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EEBEC4332F for ; Thu, 8 Dec 2022 21:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbiLHV1O (ORCPT ); Thu, 8 Dec 2022 16:27:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbiLHV1M (ORCPT ); Thu, 8 Dec 2022 16:27:12 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DF47D786AD for ; Thu, 8 Dec 2022 13:27:11 -0800 (PST) Date: Thu, 8 Dec 2022 22:27:08 +0100 From: Pablo Neira Ayuso To: Jeremy Sowden Cc: Netfilter Devel Subject: Re: [PATCH ulogd2] pgsql: correct `ulog2.ip_totlen` type Message-ID: References: <20221129211127.246934-1-jeremy@azazel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221129211127.246934-1-jeremy@azazel.net> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Nov 29, 2022 at 09:11:27PM +0000, Jeremy Sowden wrote: > The types of `ip_totlen` in the `ulog` view and the `INSERT_IP_PACKET_FULL` > function are `integer`, but the column in the `ulog2` table is `smallint`. The > "total length" field of an IP packet is an unsigned 16-bit integer, whereas > `smallint` in PostgreSQL is a signed 16-bit integer type. Change the type of > `ulog2.ip_totlen` to `integer`. Also applied this to ulogd2, thanks.