From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>,
Robert O'Brien <robrien@foxtrot-research.com>
Subject: Re: [PATCH ulogd2 3/3] src: keep IPv4 addresses internally in IPv4-in-IPv6 format
Date: Thu, 8 Dec 2022 22:45:53 +0100 [thread overview]
Message-ID: <Y5JbEVwsHcxPKI6N@salvia> (raw)
In-Reply-To: <20221127002300.191936-4-jeremy@azazel.net>
On Sun, Nov 27, 2022 at 12:23:00AM +0000, Jeremy Sowden wrote:
> Hitherto, some plug-ins have converted converted IP addresses to
> host-endianness or assumed that they already have been, and several have
> assumed that all IP addresses are IPv4. This can lead to garbled output
> if the expectations of plug-ins in a stack do not match. Convert all IP
> addresses to IPv6, using IPv4-inIPv6 for IPv4. Convert IPv4 addresses
> back for formatting.
>
> Move a couple of `ULOGD_RET_BOOL` cases for consistency.
This patch does not apply here anymore. Please, rebase.
Thanks
prev parent reply other threads:[~2022-12-08 21:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 0:22 [PATCH ulogd2 0/3] IP Address Formatting Fixes Jeremy Sowden
2022-11-27 0:22 ` [PATCH ulogd2 1/3] filter: IP2BIN: correct spelling of variable Jeremy Sowden
2022-12-08 21:45 ` Pablo Neira Ayuso
2022-11-27 0:22 ` [PATCH ulogd2 2/3] output: add missing support for int64_t values Jeremy Sowden
2022-12-08 21:45 ` Pablo Neira Ayuso
2022-11-27 0:23 ` [PATCH ulogd2 3/3] src: keep IPv4 addresses internally in IPv4-in-IPv6 format Jeremy Sowden
2022-12-08 21:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5JbEVwsHcxPKI6N@salvia \
--to=pablo@netfilter.org \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=robrien@foxtrot-research.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).