From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Julian Anastasov <ja@ssi.bg>
Cc: Li Qiong <liqiong@nfschina.com>,
Simon Horman <horms@verge.net.au>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org, coreteam@netfilter.org,
Yu Zhe <yuzhe@nfschina.com>
Subject: Re: [PATCH v2] ipvs: add a 'default' case in do_ip_vs_set_ctl()
Date: Tue, 13 Dec 2022 12:28:24 +0100 [thread overview]
Message-ID: <Y5hh2NPmmkmD4VTt@salvia> (raw)
In-Reply-To: <c3ca27a-f923-6eb6-bbe4-5e99b65c5940@ssi.bg>
On Mon, Dec 12, 2022 at 04:20:41PM +0200, Julian Anastasov wrote:
>
> Hello,
>
> On Mon, 12 Dec 2022, Li Qiong wrote:
>
> > It is better to return the default switch case with
> > '-EINVAL', in case new commands are added. otherwise,
> > return a uninitialized value of ret.
> >
> > Signed-off-by: Li Qiong <liqiong@nfschina.com>
> > Reviewed-by: Simon Horman <horms@verge.net.au>
>
> Change looks correct to me for -next, thanks!
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
Applied, thanks.
prev parent reply other threads:[~2022-12-13 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 3:25 [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl() Li Qiong
2022-12-02 10:02 ` Simon Horman
2022-12-02 10:07 ` Dan Carpenter
2022-12-02 10:18 ` liqiong
2022-12-02 10:26 ` Dan Carpenter
2022-12-02 11:26 ` Julian Anastasov
2022-12-12 7:05 ` liqiong
2022-12-12 7:43 ` [PATCH v2] ipvs: add a 'default' case " Li Qiong
2022-12-12 14:20 ` Julian Anastasov
2022-12-13 11:28 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5hh2NPmmkmD4VTt@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).