From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C1C0C4167B for ; Wed, 21 Dec 2022 16:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234467AbiLUQe2 (ORCPT ); Wed, 21 Dec 2022 11:34:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234528AbiLUQe0 (ORCPT ); Wed, 21 Dec 2022 11:34:26 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8975A29A for ; Wed, 21 Dec 2022 08:34:25 -0800 (PST) Date: Wed, 21 Dec 2022 17:34:21 +0100 From: Pablo Neira Ayuso To: Florian Westphal Cc: netfilter-devel@vger.kernel.org, kernel test robot Subject: Re: [PATCH nf] netfilter: conntrack: fix ipv6 exthdr error check Message-ID: References: <202212151110.zPbmpj0L-lkp@intel.com> <20221215141633.13253-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221215141633.13253-1-fw@strlen.de> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Dec 15, 2022 at 03:16:33PM +0100, Florian Westphal wrote: > smatch warnings: > net/netfilter/nf_conntrack_proto.c:167 nf_confirm() warn: unsigned 'protoff' is never less than zero. > > We need to check if ipv6_skip_exthdr() returned an error, but protoff is > unsigned. Use a signed integer for this. Applied, thanks